This repository has been archived by the owner on Nov 20, 2019. It is now read-only.
Url encode filename in bucket file on s3 request #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hodga That's great. Make sure you reference the issue in the commit message: It would also be nice to add the workaround Just for future wanderers, in the past we had a similar issue #19 |
|
Maybe @lucianenache can help you to release the new version once you have made the appropriate changes. |
|
Updated, will also add the workaround on #89 :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out it is not a signer issue.
First i tried encoding the path inside the Signer, but that required me to remove the encoding on "be able to add and delete files with 'weird' names" test. This again led to a Exception because of a invalid url inside WsRequest.
This might lead to backwards compatibility issue if someone else url encode their filenames already.
I guess it is possible to check if the filename already is encoded before encoding it, but i decided to keep it simple.